build: keep selector list in dist output of not pseudo-class #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8980ebb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 4.48 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailscalendar
combobox
datepicker
menu
picker
slider
stepper
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2740--spectrum-css.netlify.app |
jawinn
force-pushed
the
jawinn/css-755-not-selector-dist-format
branch
from
0204d7e
to
52cc8fa
Compare
A change in configuration had resulted in some regressions due to increased specificity created in the dist output of :not selectors. One issue was with a disabled Menu item showing a change in icon color on hover. The config override being removed here sets it back to the default stage 2 configuration that allows multiple comma separated selectors within :not(). The configuration had been converting each item in the :not selector list into its own :not selector, increasing specificity for each additional item.
jawinn
force-pushed
the
jawinn/css-755-not-selector-dist-format
branch
from
52cc8fa
to
8980ebb
Compare
rise-erpelding
approved these changes
May 9, 2024
castastrophe
approved these changes
May 10, 2024
Merged
rise-erpelding
pushed a commit
that referenced
this pull request
Jun 1, 2024
A change in configuration had resulted in some regressions due to increased specificity created in the dist output of :not selectors. One issue was with a disabled Menu item showing a change in icon color on hover. The config override being removed here sets it back to the default stage 2 configuration that allows multiple comma separated selectors within :not(). The configuration had been converting each item in the :not selector list into its own :not selector, increasing specificity for each additional item.
rise-erpelding
pushed a commit
that referenced
this pull request
Jun 4, 2024
A change in configuration had resulted in some regressions due to increased specificity created in the dist output of :not selectors. One issue was with a disabled Menu item showing a change in icon color on hover. The config override being removed here sets it back to the default stage 2 configuration that allows multiple comma separated selectors within :not(). The configuration had been converting each item in the :not selector list into its own :not selector, increasing specificity for each additional item.
rise-erpelding
pushed a commit
that referenced
this pull request
Jun 4, 2024
A change in configuration had resulted in some regressions due to increased specificity created in the dist output of :not selectors. One issue was with a disabled Menu item showing a change in icon color on hover. The config override being removed here sets it back to the default stage 2 configuration that allows multiple comma separated selectors within :not(). The configuration had been converting each item in the :not selector list into its own :not selector, increasing specificity for each additional item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change in the build configuration had resulted in some regressions due to increased specificity created in the dist output of
:notselectors. One issue was with a disabled Menu item showing a change in icon color on hover.The postcss-preset-env config override being removed here sets it to the default stage 2 configuration that allows multiple comma separated selectors within
:not(). The configuration had been using a polyfill that converted each item in the:notselector list into its own:notselector, increasing specificity for the rule for each additional item.Example:
Selector in dist CSS before this change:
.spectrum-Menu-item:hover > .spectrum-Menu-itemIcon:not(.spectrum-Menu-chevron):not(.spectrum-Menu-checkmark)Selector in dist CSS after this change (and that was generated in previous Menu 6.1.5). This is how the not selector is written in the source index.css:
.spectrum-Menu-item:hover>.spectrum-Menu-itemIcon:not(.spectrum-Menu-chevron,.spectrum-Menu-checkmark)CSS-755
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
:not(.class1):not(.class2)when defined as:not(.class, .class2). Tip: runyarn comparelocally to see the dist changes in the 7 affected components.Regression testing
Validate:
Screenshots
Bug noticed on the current state of Menu docs in main. When hovering over the disabled "Share link", the color of the icon changed:
To-do list